Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

[DON'T MERGE] RK-ARMV8-A BASE_DEVICE #2750

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Conversation

sydarn
Copy link
Contributor

@sydarn sydarn commented Jan 27, 2024

RK-ARMV8-A BASE_DEVICE

Description

This PR contains and ARMV8-A device, and the BASE_DEVICE concept. RK-ARMV8-A is a compatible virtual device that can be used to build common packages for RK3326 and RK3399.

make docker-RK-ARMV8-A
BASE_DEVICE=RK-ARMV8-A make docker-RK3326
BASE_DEVICE=RK-ARMV8-A make docker-RK3399 # dolphin-sa and duckstation-sa doesn't build yet though

Saves build time when testing on both RK3326 and RK3399. At the moment it is only used manually and doesn't interfere with existing workflows.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested Locally?

  • Test on RK3326 OGA-BE
  • Test on RK3399 RG552 (without dolphin-sa and duckstation-sa as the don't build see below)

Test Configuration:

  • Build OS name and version:
  • Docker (Y/N):
  • JELOS Branch:
  • Any additional information that may be useful:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

TODO

  • Disable image making of the RK-ARMV8-A device, this does not support flashing nor updating.
  • Solve that duckstation-sa and dolphin-sa can't locate libevdev's INCLUDE files.

Copy link
Member

@fewtarius fewtarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great :)

skip in install, will skip when marked for installation/inclusion
skip in build, will skip when dependency.

This is a bit icky as I think you could assume in catch22 situation,
Where something is marked to be skipped, but something else (marked for
installtion) depends on it. However the main reason for EXCLUDE_PKGS atm
is to exclude emulators in BASE DEVICES (RK-ARMV8-A) that shall be
device optimized for actual devices. Later we probably want to have
package flags that signal device optimization. EXCLUDE_PKGS is probably
to be marked as a power-user feature to be used at your own risk.
This is for base devices (such as RK-ARMV8-A), as they can not be
flashed.
@sydarn sydarn merged commit ae84fa4 into JustEnoughLinuxOS:dev Feb 2, 2024
@sydarn sydarn deleted the rk-armv8-a branch February 20, 2024 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants