.NET ⑨ (strongest version)

.editorconfig

@@ -75,30 +75,30 @@
 csharp_style_expression_bodied_operators = true:warning
 csharp_style_expression_bodied_properties = true:warning
 
 csharp_style_implicit_object_creation_when_type_is_apparent = true:warning
 csharp_style_inlined_variable_declaration = true:warning
 
 csharp_style_namespace_declarations = file_scoped:warning
 
 csharp_style_pattern_matching_over_as_with_null_check = true:warning
 csharp_style_pattern_matching_over_is_with_cast_check = true:warning
 
 csharp_style_prefer_extended_property_pattern = true:warning
 dotnet_style_prefer_foreach_explicit_cast_in_source = always:warning
 csharp_style_prefer_index_operator = true:warning
 csharp_style_prefer_local_over_anonymous_function = true:warning
 csharp_style_prefer_method_group_conversion = true:warning
 csharp_style_prefer_not_pattern = true:warning
 csharp_style_prefer_null_check_over_type_check = true:warning
 csharp_style_prefer_pattern_matching = true:warning
 csharp_style_prefer_primary_constructors = true:warning
 csharp_style_prefer_range_operator = true:warning
 csharp_style_prefer_readonly_struct = true:warning
 csharp_style_prefer_readonly_struct_member = true:warning
 csharp_style_prefer_switch_expression = true:warning
 csharp_style_prefer_top_level_statements = false:warning
 csharp_style_prefer_tuple_swap = true:warning
 csharp_style_prefer_utf8_string_literals = true:warning
 
 csharp_style_throw_expression = true:warning
 
@@ -115,16 +115,17 @@
 # .NET Coding Conventions     #
 ###############################
 
 dotnet_analyzer_diagnostic.severity = warning
 
 dotnet_code_quality.ca3003.excluded_symbol_names = BotController
 dotnet_code_quality.ca3012.excluded_symbol_names = BotController|CommandController
 
 dotnet_code_quality_unused_parameters = all:warning
 
+# Ignored code inspections that we do not agree with
 dotnet_diagnostic.ca1028.severity = silent
 dotnet_diagnostic.ca1031.severity = silent
 dotnet_diagnostic.ca1863.severity = silent
 
 # Rule - almost everything
 dotnet_naming_rule.almost_everything_must_be_pascal_case.severity = warning
@@ -189,14 +190,14 @@
 dotnet_naming_symbols.type_parameters.applicable_accessibilities = *
 dotnet_naming_symbols.type_parameters.applicable_kinds = type_parameter
 
 dotnet_remove_unnecessary_suppression_exclusions = none:warning
 dotnet_separate_import_directive_groups = false
 dotnet_sort_system_directives_first = true
 
 dotnet_style_coalesce_expression = true:warning
 dotnet_style_collection_initializer = true:warning
 dotnet_style_explicit_tuple_names = true:warning
 dotnet_style_namespace_match_folder = true:warning
 dotnet_style_null_propagation = true:warning
 dotnet_style_object_initializer = true:warning
 
@@ -226,6 +227,10 @@
 dotnet_style_readonly_field = true:warning
 dotnet_style_require_accessibility_modifiers = always:warning
 
+[ArchiSteamFarm/**.cs]
+# ASF project includes plugin system, therefore CA1515 typically doesn't make sense there
+dotnet_diagnostic.ca1515.severity = silent
+
 ###############################
 # JetBrains, IntelliJ/Rider   #
 ###############################

.github/workflows/ci.yml

@@ -5,7 +5,7 @@ on: [push, pull_request]
 env:
   DOTNET_CLI_TELEMETRY_OPTOUT: true
   DOTNET_NOLOGO: true
-  DOTNET_SDK_VERSION: 8.0
+  DOTNET_SDK_VERSION: 9.0
 
 permissions: {}
 

.github/workflows/publish.yml

@@ -6,7 +6,7 @@ env:
   CONFIGURATION: Release
   DOTNET_CLI_TELEMETRY_OPTOUT: true
   DOTNET_NOLOGO: true
-  DOTNET_SDK_VERSION: 8.0
+  DOTNET_SDK_VERSION: 9.0
   NODE_JS_VERSION: 'lts/*'
   PLUGINS_BUNDLED: ArchiSteamFarm.OfficialPlugins.ItemsMatcher ArchiSteamFarm.OfficialPlugins.MobileAuthenticator ArchiSteamFarm.OfficialPlugins.SteamTokenDumper
   PLUGINS_INCLUDED: ArchiSteamFarm.OfficialPlugins.Monitoring # Apart from declaring them here, there is certain amount of hardcoding needed below for uploading
@@ -170,7 +170,7 @@ jobs:
         if [ "$VARIANT" = 'generic' ]; then
             variantArgs="-p:TargetLatestRuntimePatch=false -p:UseAppHost=false"
         else
-            variantArgs="-p:PublishSingleFile=true -p:PublishTrimmed=true -r $VARIANT --self-contained"
+            variantArgs="-p:PublishSingleFile=true -r $VARIANT --self-contained"
         fi
 
         dotnet publish ArchiSteamFarm -c "$CONFIGURATION" -o "out/${VARIANT}" "-p:ASFVariant=${VARIANT}" -p:ContinuousIntegrationBuild=true --nologo $variantArgs
@@ -204,7 +204,7 @@ jobs:
         if ($env:VARIANT -like 'generic*') {
             $variantArgs = '-p:TargetLatestRuntimePatch=false', '-p:UseAppHost=false'
         } else {
-            $variantArgs = '-p:PublishSingleFile=true', '-p:PublishTrimmed=true', '-r', "$env:VARIANT", '--self-contained'
+            $variantArgs = '-p:PublishSingleFile=true', '-r', "$env:VARIANT", '--self-contained'
         }
 
         dotnet publish ArchiSteamFarm -c "$env:CONFIGURATION" -o "out\$env:VARIANT" "-p:ASFVariant=$env:VARIANT" -p:ContinuousIntegrationBuild=true --nologo $variantArgs

Directory.Build.props

@@ -29,7 +29,7 @@
 		<RepositoryUrl>$(PackageProjectUrl).git</RepositoryUrl>
 		<RollForward>LatestMajor</RollForward>
 		<RuntimeIdentifiers>linux-arm;linux-arm64;linux-x64;osx-arm64;osx-x64;win-arm64;win-x64</RuntimeIdentifiers>
-		<TargetFramework>net8.0</TargetFramework>
+		<TargetFramework>net9.0</TargetFramework>
 		<TargetLatestRuntimePatch>true</TargetLatestRuntimePatch>
 	</PropertyGroup>
 
@@ -50,7 +50,7 @@
 		<DebugType>none</DebugType>
 		<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
 		<WarningsAsErrors />
-		<WarningsNotAsErrors>CA1863,CS8002,IL2026,IL2104,NU1901,NU1902,NU1903,NU1904</WarningsNotAsErrors>
+		<WarningsNotAsErrors>CS8002,IL2026,IL2104,NU1901,NU1902,NU1903,NU1904</WarningsNotAsErrors>
 	</PropertyGroup>
 
 	<!-- Enable public signing if not part of Visual Studio, which is too stupid to understand what public signing is -->

Dockerfile

@@ -15,7 +15,7 @@ RUN <<EOF
     npm run deploy --no-progress
 EOF
 
-FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:8.0${IMAGESUFFIX} AS build-dotnet
+FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:9.0-preview${IMAGESUFFIX} AS build-dotnet
 ARG CONFIGURATION=Release
 ARG TARGETARCH
 ARG TARGETOS
@@ -76,7 +76,7 @@ RUN --mount=type=secret,id=ASF_PRIVATE_SNK --mount=type=secret,id=STEAM_TOKEN_DU
     done
 EOF
 
-FROM --platform=$TARGETPLATFORM mcr.microsoft.com/dotnet/aspnet:8.0${IMAGESUFFIX} AS runtime
+FROM --platform=$TARGETPLATFORM mcr.microsoft.com/dotnet/aspnet:9.0-preview${IMAGESUFFIX} AS runtime
 ENV ASF_PATH=/app
 ENV ASF_USER=asf
 ENV ASPNETCORE_URLS=

Dockerfile.Service

@@ -15,7 +15,7 @@ RUN <<EOF
     npm run deploy --no-progress
 EOF
 
-FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:8.0${IMAGESUFFIX} AS build-dotnet
+FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:9.0-preview${IMAGESUFFIX} AS build-dotnet
 ARG CONFIGURATION=Release
 ARG TARGETARCH
 ARG TARGETOS
@@ -57,7 +57,7 @@ RUN --mount=type=secret,id=ASF_PRIVATE_SNK --mount=type=secret,id=STEAM_TOKEN_DU
         echo "WARN: No ASF_PRIVATE_SNK provided!"
     fi
 
-    dotnet publish ArchiSteamFarm -c "$CONFIGURATION" -o "out" "-p:ASFVariant=${asf_variant}" -p:ContinuousIntegrationBuild=true -p:PublishSingleFile=true -p:PublishTrimmed=true -r "$asf_variant" --nologo --self-contained
+    dotnet publish ArchiSteamFarm -c "$CONFIGURATION" -o "out" "-p:ASFVariant=${asf_variant}" -p:ContinuousIntegrationBuild=true -p:PublishSingleFile=true -r "$asf_variant" --nologo --self-contained
 
     if [ -f "/run/secrets/STEAM_TOKEN_DUMPER_TOKEN" ]; then
         STEAM_TOKEN_DUMPER_TOKEN="$(cat "/run/secrets/STEAM_TOKEN_DUMPER_TOKEN")"
@@ -76,7 +76,7 @@ RUN --mount=type=secret,id=ASF_PRIVATE_SNK --mount=type=secret,id=STEAM_TOKEN_DU
     done
 EOF
 
-FROM --platform=$TARGETPLATFORM mcr.microsoft.com/dotnet/runtime-deps:8.0${IMAGESUFFIX} AS runtime
+FROM --platform=$TARGETPLATFORM mcr.microsoft.com/dotnet/runtime-deps:9.0-preview${IMAGESUFFIX} AS runtime
 ENV ASF_PATH=/app
 ENV ASF_USER=asf
 ENV ASPNETCORE_URLS=