Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2FA endpoints #2921

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Fix 2FA endpoints #2921

merged 3 commits into from
Jun 21, 2023

Conversation

ezhevita
Copy link
Member

Checklist

  • I read and understood the Contributing Guidelines.
  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • My code follows the code style of this project.
  • I have added tests to cover my changes, wherever they are necessary.
  • All new and existing tests pass.

Changes

New functionality

None.

Changed functionality

Fixed getting 2FA confirmations (resolves #2920)

Removed functionality

None.

Additional info

thanks steam very cool
TODO: add session update if needauth

@ezhevita
Copy link
Member Author

// Confirmations page is notorious for freezing, not returning confirmations and other issues
// It's unknown what exactly causes those problems, but restart of the bot fixes those in almost all cases
// Normally this wouldn't make any sense, but let's ensure that we've refreshed our session recently as a possible workaround
if (DateTime.UtcNow - SessionValidUntil > TimeSpan.FromMinutes(5)) {
if (!await RefreshSession().ConfigureAwait(false)) {
return null;
}
}

also this may not be needed anymore, there is a glimmer of hope they finally fixed this

@JustArchi JustArchi added the 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. label Jun 21, 2023
@JustArchi
Copy link
Member

@ezhevita Thanks a lot for doing the hard part and sending PR, your support and help is priceless! 🏆

@JustArchi JustArchi merged commit 7132340 into JustArchiNET:main Jun 21, 2023
@ezhevita ezhevita deleted the fix-2fa branch June 21, 2023 11:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steam confirmation endpoint change
2 participants