Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if bot online before checking for outstanding trades. Bugfix for #2871 #2887

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Check if bot online before checking for outstanding trades. Bugfix for #2871 #2887

merged 1 commit into from
Apr 23, 2023

Conversation

Rudokhvist
Copy link
Member

@Rudokhvist Rudokhvist commented Apr 23, 2023 •
edited
Loading

Checklist

  • I read and understood the Contributing Guidelines.
  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • My code follows the code style of this project.
  • I have added tests to cover my changes, wherever they are necessary.
  • All new and existing tests pass.

Changes

Fixes an error introduced in #2871 - offline bots were trying to check for oustanding trades too.

New functionality

just a fix, no new functionality

Changed functionality

Offline bots don't try to check for outstanding trades.

Removed functionality

none

Additional info

Sorry about that.

@Rudokhvist Rudokhvist requested review from Abrynos and JustArchi April 23, 2023 08:53
@Abrynos
Copy link
Member

Abrynos commented Apr 23, 2023

That should do it. Thanks for the quick fix!

@Abrynos Abrynos added 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. labels Apr 23, 2023
@JustArchi JustArchi merged commit 7721106 into JustArchiNET:main Apr 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustArchi JustArchi JustArchi approved these changes

@Abrynos Abrynos Awaiting requested review from Abrynos

Assignees
No one assigned
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rudokhvist @Abrynos @JustArchi