Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented native web GUI support for plugins inside the ASF IPC. Closes #2876 #2877

Merged
merged 39 commits into from
Apr 20, 2023
Merged

Implemented native web GUI support for plugins inside the ASF IPC. Closes #2876 #2877

merged 39 commits into from
Apr 20, 2023

Conversation

fazelukario
Copy link
Contributor

@fazelukario fazelukario commented Apr 10, 2023 •
edited
Loading

Checklist

  • I read and understood the Contributing Guidelines.
  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • My code follows the code style of this project.
  • I have added tests to cover my changes, wherever they are necessary.
  • All new and existing tests pass.

Changes

New functionality

Added native web GUI support for custom plugins inside the ASF IPC

Changed functionality

None

Removed functionality

None

Additional info

ref #2876

@fazelukario fazelukario marked this pull request as ready for review April 10, 2023 16:23
@fazelukario fazelukario mentioned this pull request Apr 10, 2023
Closed
7 tasks
@fazelukario fazelukario changed the title Implemented native web GUI support for plugins inside the ASF IPC Implemented native web GUI support for plugins inside the ASF IPC. Closes #2876. Apr 10, 2023
@fazelukario fazelukario changed the title Implemented native web GUI support for plugins inside the ASF IPC. Closes #2876. Implemented native web GUI support for plugins inside the ASF IPC. Closes #2876 Apr 10, 2023
JustArchi
JustArchi requested changes Apr 10, 2023
View reviewed changes
@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🔧 Fixes required Issues marked with this label require further follow-up fixes before they can be considered. labels Apr 10, 2023
Abrynos
Abrynos reviewed Apr 11, 2023
View reviewed changes
JustArchi
JustArchi requested changes Apr 11, 2023
View reviewed changes
Abrynos
Abrynos reviewed Apr 11, 2023
View reviewed changes
@fazelukario fazelukario requested a review from JustArchi April 15, 2023 15:07
JustArchi
JustArchi approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some misc changes I'd still do but that can be taken care of post-PR when I also evaluate netf compatibility.

Good job! 🏆

@JustArchi
Copy link
Member

@Abrynos @Ryzhehvost feel free to review.

@JustArchi JustArchi added 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. and removed 🔧 Fixes required Issues marked with this label require further follow-up fixes before they can be considered. labels Apr 15, 2023
Abrynos
Abrynos reviewed Apr 16, 2023
View reviewed changes
@fazelukario fazelukario requested a review from Abrynos April 19, 2023 11:47
@fazelukario
Copy link
Contributor Author

@JustArchi @Abrynos @Ryzhehvost Done with feedback, feel free to review.

@Rudokhvist
Copy link
Member

LGTM. IWebInterface should probably have self-documentation comments for properties, but that's not a show-stopper.

Abrynos
Abrynos approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@Abrynos Abrynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fazelukario
Copy link
Contributor Author

LGTM. IWebInterface should probably have self-documentation comments for properties, but that's not a show-stopper.

Yes, I forgot about this, but I think it would be better if @JustArchi documented this as I'm not very good at writing user friendly documentation.

@JustArchi
Copy link
Member

Enough of chit-chat, time to merge that in!

Thanks again 🏆

@JustArchi JustArchi merged commit 97da56d into JustArchiNET:main Apr 20, 2023
@fazelukario fazelukario deleted the patch-1 branch April 20, 2023 23:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustArchi JustArchi JustArchi approved these changes

@Abrynos Abrynos Abrynos approved these changes

@Rudokhvist Rudokhvist Rudokhvist approved these changes

Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 🏁 Finished Issues marked with this label were finished already and no further work is required on them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fazelukario @JustArchi @Rudokhvist @Abrynos