Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login keys are no longer being generated #2840

Closed
7 tasks done
JustArchi opened this issue Mar 14, 2023 · 0 comments · Fixed by #2843
Closed
7 tasks done

Login keys are no longer being generated #2840

JustArchi opened this issue Mar 14, 2023 · 0 comments · Fixed by #2843
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. 🤝 Help welcome Issues marked with this label are open for help. If you could offer us a hand, please do! 🟡 Medium priority Issues marked with this label have a priority, unless there is something even more important. 💥 Regression Issues marked with this label are regressions - bugs that were introduced recently.

Comments

@JustArchi
Copy link
Member

Checklist

ASF version

Latest stable release

ASF variant

generic (with latest .NET runtime)

Bug description

Login keys seems to be no longer generated on the Steam side, this results in ASF going through full login procedure each time if the user is using Steam guard without ASF 2FA.

Expected behavior

Should work like before and not require from user credentials each time.

Actual behavior

2FA code asked on each run without ASF 2FA.

Steps to reproduce

No response

Possible reason/solution

SteamRE/SteamKit#1129

Can you help us with this bug report?

Yes, I can code the solution myself and send a pull request

Full log.txt recorded during reproducing the problem

Not relevant

Global ASF.json config file

No response

BotName.json config of all affected bot instances

No response

Additional info

No response
@JustArchi JustArchi added 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. 🤝 Help welcome Issues marked with this label are open for help. If you could offer us a hand, please do! 🟡 Medium priority Issues marked with this label have a priority, unless there is something even more important. 💥 Regression Issues marked with this label are regressions - bugs that were introduced recently. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. 💢 No solution yet Issues marked with this label indicate that we don't have any idea how to solve this problem yet. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. labels Mar 14, 2023
@tpill90 tpill90 mentioned this issue Mar 16, 2023
Closed
@JustArchi JustArchi removed the 💢 No solution yet Issues marked with this label indicate that we don't have any idea how to solve this problem yet. label Mar 16, 2023
@JustArchi JustArchi mentioned this issue Mar 16, 2023
Merged
@plantroon plantroon mentioned this issue Mar 17, 2023
Closed
JustArchi added a commit that referenced this issue Mar 17, 2023
@JustArchi
Closes #2840 (#2843)
dd663f4 
* Initial login flow changes

* I hate windows

* Make it compile

* Hehe, you bet

* Another approach

* Misc

* Misc

* Final touches

* Misc

* Okay xpaw

* xPaw update

* Keep set input for reconnection

* Unify login errors

* Add missing registry entry

* Final touches before I lose my sanity
@Rudokhvist Rudokhvist mentioned this issue Mar 26, 2023
Closed
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
@JustArchi JustArchi added the 🏁 Finished Issues marked with this label were finished already and no further work is required on them. label Jun 17, 2024
@JustArchi JustArchi removed the 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. label Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. 🤝 Help welcome Issues marked with this label are open for help. If you could offer us a hand, please do! 🟡 Medium priority Issues marked with this label have a priority, unless there is something even more important. 💥 Regression Issues marked with this label are regressions - bugs that were introduced recently.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2840 JustArchiNET/ArchiSteamFarm
1 participant
@JustArchi