Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for displaying plugins GUI URL #1634

Open
5 tasks done
fazelukario opened this issue Jun 22, 2023 · 2 comments
Open
5 tasks done

Add support for displaying plugins GUI URL #1634

fazelukario opened this issue Jun 22, 2023 · 2 comments
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🤝 Help welcome Issues marked with this label are open for help. If you could offer us a hand, please do! 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request.

Comments

@fazelukario
Copy link

Checklist

  • I read and understood ASF-ui's Contributing Guidelines
  • I also read FAQ
  • My idea doesn't duplicate existing ASF-ui functionality described on the wiki
  • I believe that my idea falls into ASF-ui's scope and should be offered as part of ASF-ui built-in functionality
  • This is not ASF suggestion

Enhancement purpose

Convenience

Solution

The title speaks for itself.
Add support to render plugins gui url.

Why currently available solutions are not sufficient?

More convenience!

Can you help us with this enhancement idea?

Somehow, I can test and offer feedback, but can't code

Additional info

Since ASF now officially supports plugins GUI (as of V5.4.5.2, reference #2877 #2876 ) it would be nice to display URLs of plugins interfaces in ASF-ui.

All plugins that have a GUI must pass a WebPath that can be used to display a link to the plugin's GUI. (The WebPath is sent by ASF along with the plugin name, reference)

For example, it would be nice to add a link button next to the plugin name (if the plugin has a GUI) to open the plugin's GUI page in a new window, it would also be cool to add a second button that opens the plugin GUI inside the ASF-ui (<iframe> it inside the main window, reference to screenshot 2).

image
Screenshot 1. Globe for open in new tab, laptop for embed into ASF-ui (just for examle).

image
Screenshot 2. Embeded plugin GUI (market white).

Also, the plugin GUI URLs can be here:

image
Screenshot 3. Globe for open in new tab, laptop for embed into ASF-ui (just for examle).
@fazelukario fazelukario added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 22, 2023
@fazelukario fazelukario changed the title Add support to render plugins gui url Add support for displaying plugins GUI URL Jun 22, 2023
@Aareksio Aareksio added 🤝 Help welcome Issues marked with this label are open for help. If you could offer us a hand, please do! 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. and removed 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 23, 2023
@MrBurrBurr
Copy link
Member

Can you provide an example plugin for both scenarios?

@fazelukario
Copy link
Author

Ok, give me a couple of days, I'll write an example plugin when I have some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🤝 Help welcome Issues marked with this label are open for help. If you could offer us a hand, please do! 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Aareksio @MrBurrBurr @fazelukario