Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASF reconnect loop #46

Closed
JustArchi opened this issue Dec 22, 2015 · 26 comments
Closed

ASF reconnect loop #46

JustArchi opened this issue Dec 22, 2015 · 26 comments
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 🟡 Medium priority Issues marked with this label have a priority, unless there is something even more important.

Comments

@JustArchi
Copy link
Member

Usual log looks like this:

12/22/2015 10:47:39 AM [*] INFO: Start() <spoilbot2> Starting...
12/22/2015 10:47:44 AM [*] INFO: OnDisconnected() <spoilbot2> Disconnected from Steam, reconnecting...
12/22/2015 10:47:44 AM [*] INFO: OnConnected() <spoilbot2> Connected to Steam!
12/22/2015 10:47:44 AM [*] INFO: OnLoggedOn() <spoilbot2> Successfully logged on!
12/22/2015 10:47:46 AM [*] INFO: Init() <spoilbot2> Logging in to ISteamUserAuth...
12/22/2015 10:47:46 AM [*] INFO: Init() <spoilbot2> Success!
12/22/2015 10:47:47 AM [*] INFO: StartFarming() <spoilbot2> Checking possibility to farm...
12/22/2015 10:47:49 AM [*] INFO: OnDisconnected() <spoilbot2> Disconnected from Steam, reconnecting...
12/22/2015 10:47:49 AM [*] INFO: StopFarming() <spoilbot2> Sending signal to stop farming
12/22/2015 10:47:49 AM [*] INFO: StopFarming() <spoilbot2> Waiting for reaction...
12/22/2015 10:47:49 AM [*] INFO: OnConnected() <spoilbot2> Connected to Steam!
12/22/2015 10:47:49 AM [*] INFO: OnLoggedOn() <spoilbot2> Successfully logged on!
12/22/2015 10:47:50 AM [*] INFO: Init() <spoilbot2> Logging in to ISteamUserAuth...
12/22/2015 10:47:50 AM [*] INFO: StopFarming() <spoilbot2> Farming stopped!
12/22/2015 10:47:50 AM [*] INFO: Init() <spoilbot2> Success!
12/22/2015 10:47:50 AM [*] INFO: StartFarming() <spoilbot2> Checking possibility to farm...
12/22/2015 10:47:55 AM [*] INFO: OnDisconnected() <spoilbot2> Disconnected from Steam, reconnecting...

This issue happened to @Ryzhehvost as well as other people (KnSYS).

I can't reproduce it and I can't think of any explanation why it would happen to one account on very rare basis. It doesn't make sense to me for now.

I suspect it might be because of the PlayGames() request sent during the check, even if that doesn't make any sense, perhaps for some reason it makes Steam send Disconnect, so ASF tries to reconnect and so on.

I suggest everybody who notices that issue to update to latest pre-release and try hard to reproduce the bug, only if nobody succeeds after 2-3 days I will assume that this is the reason, because there is literally no way for me to check - random bugs with absolutely no logic are the worst ones.
@JustArchi JustArchi added 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ⁉️ Can't reproduce Issues marked with this label can't be reproduced by the developer, more info needed. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. 🔴 High priority Issues marked with this label indicate the most serious problems, especially security-related. labels Dec 22, 2015
@JustArchi
Copy link
Member Author

Also fixed a misc derp with pre1, pre2 should be fine for testing.

@Rudokhvist
Copy link
Member

Testing for a few days without my extra commands? Darn. Ok, I'll do this for Aiur.

@JustArchi
Copy link
Member Author

You can always compile yourself and add your extra bits. I do not release closed-source pre-releases. The objective is to find root cause.

@Rudokhvist
Copy link
Member

Of course I can. But then we'll never know if it's caused by my modifications.

@JustArchi
Copy link
Member Author

If KnSYS reproduced the issue on "vanilla" ASF, most likely your modifications don't have any negative impact.

I mean, 99% of "hard to explain" bugs are directly caused by volvo fuckups, the thing is to add workaround for them. This is how whole SteamKit2 works, and all projects based on that too.

@JustArchi
Copy link
Member Author

Also I still have your pull request in mind, I didn't forget about that. Maybe I'll add those bits even to 1.2, but ASF reconnect loop issue is definitely with highest priority, it literally fucks up things.

@Rudokhvist
Copy link
Member

I'm quite agree that this has highest priority, that's why I said I'll do it.

@JustArchi
Copy link
Member Author

It would be much easier if I could reproduce that issue myself, or at least find any logical explanation why it happens instead of assuming things out of the blue.

However, in this case most likely I'd fix that issue around V0.2 release, and not 1.2.

Therefore, the only thing I can do is provide everybody with 1.2 pre2 and suggest to try hard to reproduce the bug, because I'm literally blindly trying to fix thing I don't even know about.

@Rudokhvist
Copy link
Member

Maybe you should have added some extra logging to this release then?

@v3rg
Copy link

v3rg commented Dec 22, 2015

Got the same problem with several alts(always the same alts). Will test this too.

@JustArchi
Copy link
Member Author

Extra logging won't help. I need confirmation if my assumption is correct, nothing else.

@JustArchi
Copy link
Member Author

Please test pre3 instead - https://github.com/JustArchi/ArchiSteamFarm/releases/tag/1.2.0.0-pre3

I rewrote how cards farming module works now, which should potentially solve this and other issues.

Basically the most important fact is that if ASF issues SteamClient.Disconnect(), it doesn't try to reconnect in the callback, but if Steam issued Disconnect, it will try.

@Rudokhvist
Copy link
Member

Ok. May I ask, why !farm was removed?

@JustArchi
Copy link
Member Author

It was removed for two reasons

  • It directly affected cards farming module, and I don't want to do that anymore to make it more reliable
  • It is not necessary anymore, as ASF now automatically resumes farming if it's finished with no drops

@JustArchi
Copy link
Member Author

In other words, I see no use of that command anymore, ASF handles itself all possible problems, including resume of farming after some time if you e.g. activate gift, as well as handling steam network disconnects and other stuff. Having obsolete commands which serve no purpose is pointless.

@Rudokhvist
Copy link
Member

That would mean a delay upto 15 minutes after gift activation can occur. I'm okay with that, because I rarely buy gifts for bots, but someone who does can be annoyed by this delay.

@JustArchi
Copy link
Member Author

Someone who does can issue !stop and !start if he is in so much hurry that he can't wait 15 minutes.

Be realistic. If it was 1-day check I'd understand, but not 15 minutes.

@JustArchi
Copy link
Member Author

Also when #18 is done, handling gifts will restart farming module as well.

@Rudokhvist
Copy link
Member

!stop+!start is even better. We need one command for this.

@JustArchi JustArchi added the 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. label Dec 23, 2015
@v3rg v3rg mentioned this issue Dec 23, 2015
Closed
@JustArchi JustArchi added 🟡 Medium priority Issues marked with this label have a priority, unless there is something even more important. and removed ⁉️ Can't reproduce Issues marked with this label can't be reproduced by the developer, more info needed. 🔴 High priority Issues marked with this label indicate the most serious problems, especially security-related. labels Dec 23, 2015
@JustArchi
Copy link
Member Author

Leaving it open for a few more days, if anybody reproduces with 1.2.1 let me know.

@JustArchi
Copy link
Member Author

I'm more and more convinced that the real issue was PlayGames request, which because of some Volvo fuckup with certain CM could cause Disconnect in some rare scenario. Since removing it from 1.2+ onwards I didn't hear any complain yet.

We can only hope for the best and keep an eye on that.

@judgegr
Copy link

judgegr commented Dec 23, 2015

I think i had this too, please check my log file to confirm it, in case it's something else and got confused.

Now, i've just updated to 1.2.1 and put it under surveillance. No problems so far ;)
log_bkp.txt

@JustArchi
Copy link
Member Author

No, this is not that issue.

@JustArchi
Copy link
Member Author

Fingers crossed?

@JustArchi
Copy link
Member Author

Around a week has passed and nobody reported similar issues, I couldn't stumble upon them as well.

I consider this issue as fixed, thanks for testing.

@Rudokhvist
Copy link
Member

Seems like issue is solved, but if you want to closely examine full log of about ~4 days online, contact me in steam, i'm gladly provide it to you.

@Pandiora Pandiora mentioned this issue Feb 21, 2016
Closed
@JustArchiNET JustArchiNET deleted a comment from Arslan30 May 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 🟡 Medium priority Issues marked with this label have a priority, unless there is something even more important.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustArchi @v3rg @judgegr @Rudokhvist