Added Mountpoint Param

[asergeant01]

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4

Type of change

Please delete options that are not relevant.

• [ X] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

• Python Version: 3.9
• Vault Version: Vault 1.6.2+prem

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Mentions:

@Just-Insane

[Just-Insane]

Would you be able to add some tests and update the documentation?

I see your PR also updates the default KV Version to v2 and removed/changed some other sections of the code. Unless these are critical changes in order to support the mount point parameter, could they be broken out to another PR?

[asergeant01]

I've updated the documentation and reset the kv version to default to v1.

I'm not sure what tests need added additionally? I believe you have tests to check the Environment variables / Args are processed correctly and you have integration tests using hvac which should test the mount path.

The only thing not required for Mount Path is the Envs refactoring, which i changed as i found having to look up positional variables and referencing the return order from the get_envs function a little confusing - hopefully this is straight forward enough that it doesn't warrant a separate PR?

[Just-Insane]

looks good to me!