Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass a file containing the secrets during encoding action #3

Merged
merged 5 commits into from
Apr 1, 2020

Conversation

reynardmh
Copy link

@reynardmh reynardmh commented Dec 2, 2019

Add option to pass secret file

Description

This change lets you pass a file containing the secrets. Copy values.yaml to values.yaml.dec and replace the deliminators with the actual secret, then run:

$ helm vault enc values.yaml -s values.yaml.dec

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

$ python3 -m pytest 

Test Configuration:

  • Python Version: 3.7.3
  • Vault Version: 1.3.0

Tested to work with Helm Version 2.14.3 and 3.0.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Owner

@Just-Insane Just-Insane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good! Thanks for the tests.

@Just-Insane Just-Insane merged commit f992b94 into Just-Insane:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants