Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove duplicate read/send code in connection #350

Merged
merged 5 commits into from
Oct 29, 2024
Merged

chore: remove duplicate read/send code in connection #350

merged 5 commits into from
Oct 29, 2024

Conversation

JurgenR
Copy link
Owner

@JurgenR JurgenR commented Oct 28, 2024

Closes #349

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Test Results

    9 files  ± 0      9 suites  ±0   7m 30s ⏱️ +5s
  740 tests + 2    740 ✅ + 2  0 💤 ±0  0 ❌ ±0 
6 660 runs  +18  6 660 ✅ +18  0 💤 ±0  0 ❌ ±0 

Results for commit 715e45f. ± Comparison against base commit fde8a17.

♻️ This comment has been updated with latest results.

@JurgenR JurgenR changed the title chore: remove duplicate code chore: remove duplicate read/send code in connection Oct 29, 2024
@JurgenR JurgenR merged commit df9d3ff into main Oct 29, 2024
12 checks passed
@JurgenR JurgenR deleted the chore/remove-duplicate-read-send branch October 29, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network: Merge receive_data and _read methods
1 participant
@JurgenR