Use _attr_native_value instead of _attr_state in sensor entity #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurajNyiri
requested changes
Jul 20, 2024
…anup in sensor entity
|
@JurajNyiri any luck checking this out? My goal here is to get this approved first, then move on to making the HDD storage sensors appropriately represent numeric data with the DATA_SIZE device class and UnitOfInformation measurements. |
|
Thank you for the reminder and PR, I was very busy lately. I will try to review and test this during the weekend. |
No worries, just didn't want it to get lost! |
|
Thank you! Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stateproperty of a sensor entity is marked as final in Home Assistant code and should not be used for a sensor's state. Instead the recommendation is to use thenative_valueproperty. This switches the code to use_attr_native_valueinstead of_attr_stateas well as some additional cleanup in the sensor.py file for readability.See https://github.com/home-assistant/core/blob/dev/homeassistant/components/sensor/__init__.py#L538
and https://developers.home-assistant.io/docs/core/entity/sensor