Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add cr episodes 0 54 #568

Merged

Conversation

ChanceM
Copy link
Contributor

@ChanceM ChanceM commented Sep 14, 2023

Resolves #222

Add content for episodes and add image (EP 38).
If podcast_file is None try to play direct files.

"podcast_bytes": null,
"podcast_chapters": null,
"podcast_alt_file": "https://traffic.libsyn.com/jnite/thedust-mp3.mp3",
"podcast_ogg_file": "https://traffic.libsyn.com/jnite/thedust-ogg.ogg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't point to a file anymore, including anything with libsyn.com/jnite (Jupiter@Nite, the old JB show?)

@reclaimingmytime
Copy link
Contributor

reclaimingmytime commented Sep 18, 2023

To to make the old episodes accessible, we would have to re-host them on a different server. This is part of issue #154, along with all the other unmigrated JB shows.

@ChanceM
Copy link
Contributor Author

ChanceM commented Sep 19, 2023

To to make the old episodes accessible, we would have to re-host them on a different server. This is part of issue #154, along with all the other unmigrated JB shows.

Yes, my goal here was to mainly add back content to an active show and to keep it as close to the original content as possible. For that matter JB could rip the audio and add them all back to fireside.

Copy link
Collaborator

@CGBassPlayer CGBassPlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all. This is really impressive and is greatly appreciated. I am not sure how you got all the early coder episodes, but I love that you did! 🙂

I do think that the Show Notes title or the Episode Links title in the markdown needs be removed. Having both does not look that good.
image

The other issue I saw when testing the page is that the tags title still appears even when there is no tags. I already have code ready to fix this (just a quick conditional in the template) so no need to worry about that.

Last thing @reclaimingmytime had already pointed out being the the links that are dead. Not sure where their new location is but we should probably ask JB if they still have them hosted somewhere.

content/show/coder-radio/0001.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@CGBassPlayer CGBassPlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can live with some of the links being dead for now. I think what we have now will be good enough for the time being and we can address the 404 links when the archive site starts.

@CGBassPlayer CGBassPlayer merged commit 630b3fb into JupiterBroadcasting:develop Jan 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JB - need information information is needed from the JB team show notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Coder Radio] Episodes 1-54 Missing
3 participants