-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace checkboxes with drop down in issue form #443
Replace checkboxes with drop down in issue form #443
Conversation
I may close this PR and open a new one to remove the commits from the scraper |
could try a force push on your repo's feature branch? would that work instead? |
So when I look at the branch in my repo, it says I am only 1 commit ahead of develop instead of 4 so it may be fine when we merge this |
I agree, seems just fine now. Let us know when its ready for review! |
err, one consideration for dropdowns instead of checkboxes: it eliminates the possibility for the Issue author to make multiple selections, which I found useful already. This feels like one of those conpromise scenarios.. no ideal path, just a choice of loss of functionality. the Q becomes: do we prefer multi-selections or less issue-tracked checkboxes interpreted as "tasks" ? I'm not so sure.... Now I may be leaning toward keeping as is, cobsidering the above. Hmm! What do you all think? |
The drop down does allow multiple options to be selected if you enable The only thing I need to know is if we should remove the checkbox for contributing guidelines because that is what is creating a task on the issue. What are your thoughts on that? |
We can talk about the contributing check box in the future |
Ok, I say drop the Contributor Guidelines check box - if someone actually wants to read it, they will. If not, they'll just check the box. Doesn't necessarily give us more or less information either way. |
Also: that IS a wonderful drop down feature - nice! Thanks for keeping me focused. |
@gerbrent this is all set for your review |
Closes #390