Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace checkboxes with drop down in issue form #443

Merged

Conversation

CGBassPlayer
Copy link
Collaborator

@CGBassPlayer CGBassPlayer commented Oct 4, 2022

Closes #390

  • Change checkboxes to dropdowns to prevent issue details being marked as tasks

@CGBassPlayer
Copy link
Collaborator Author

I may close this PR and open a new one to remove the commits from the scraper

@gerbrent
Copy link
Collaborator

gerbrent commented Oct 7, 2022

could try a force push on your repo's feature branch? would that work instead?

@CGBassPlayer
Copy link
Collaborator Author

So when I look at the branch in my repo, it says I am only 1 commit ahead of develop instead of 4 so it may be fine when we merge this

@gerbrent
Copy link
Collaborator

gerbrent commented Oct 9, 2022

I agree, seems just fine now. Let us know when its ready for review!

@gerbrent
Copy link
Collaborator

gerbrent commented Oct 9, 2022

err, one consideration for dropdowns instead of checkboxes: it eliminates the possibility for the Issue author to make multiple selections, which I found useful already.

This feels like one of those conpromise scenarios.. no ideal path, just a choice of loss of functionality.

the Q becomes: do we prefer multi-selections or less issue-tracked checkboxes interpreted as "tasks" ? I'm not so sure....

Now I may be leaning toward keeping as is, cobsidering the above. Hmm!

What do you all think?

@CGBassPlayer
Copy link
Collaborator Author

CGBassPlayer commented Oct 9, 2022

The drop down does allow multiple options to be selected if you enable multiple: true on the drop-down (which I did in this case to maintain functionality). This can actually be seen in the browser selection and device selection when someone reports a website issue.

The only thing I need to know is if we should remove the checkbox for contributing guidelines because that is what is creating a task on the issue. What are your thoughts on that?

@CGBassPlayer
Copy link
Collaborator Author

We can talk about the contributing check box in the future

@CGBassPlayer CGBassPlayer marked this pull request as ready for review October 11, 2022 02:24
@CGBassPlayer CGBassPlayer requested a review from gerbrent October 11, 2022 02:24
@CGBassPlayer CGBassPlayer changed the title Issue Form Updates Replace checkboxes with drop downs in issue form Oct 11, 2022
@CGBassPlayer CGBassPlayer changed the title Replace checkboxes with drop downs in issue form Replace checkboxes with drop down in issue form Oct 11, 2022
@gerbrent
Copy link
Collaborator

Ok, I say drop the Contributor Guidelines check box - if someone actually wants to read it, they will. If not, they'll just check the box. Doesn't necessarily give us more or less information either way.

@gerbrent
Copy link
Collaborator

Also: that IS a wonderful drop down feature - nice! Thanks for keeping me focused.

@CGBassPlayer
Copy link
Collaborator Author

@gerbrent this is all set for your review

@gerbrent gerbrent merged commit bc83a0e into JupiterBroadcasting:develop Oct 11, 2022
@CGBassPlayer CGBassPlayer deleted the bugfix/issue-templates branch October 12, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue and/or PR Templates
2 participants