Add basic Issue and PR Templates #410
Conversation
…yer/jupiterbroadcasting.com into feature/issue-template
|
THIS IS SO GREAT - thanks @CGBassPlayer . |
…ate' into feature/issue-template
There was a problem hiding this comment.
A few small details/questions that I think might enhance it a bit more, but IMO optional. Very nicely done @CGBassPlayer !
It might be nice to have screenshots of each template as well, just so we can capture what they looked like for this PR.
Also, I don't known how familiar you are with git, but what I've done when I needed to merge something with my main branch to demonstrate functionality for something. Is after I merge it I reset it to JB repo's HEAD.
So, I've already added JB's repo as a remote with: git remote add upstream https://github.com/JupiterBroadcasting/infra.git
Then if I've merged my branch already and I want to reset my main branch I run: git reset --hard upstream/main and then I have to force push (since I'm re-writing history for my git repo): git push -f.
I will say though, be careful with force pushes (it can be a dangerous thing and unrecoverable (like how I messed up here and had to re-implement my previous work)), so just make sure to use it sparingly.
So besides the suggestions I've made and potential screenshots as enhancements everything from a functionality perspective LGTM. This is going to be an awesome addition to the repo! Thanks again @CGBassPlayer for doing all this research/work!
(Going to leave this open for @gerbrent since he showed interest in it before)
| For dead links, if you find a working link, please add it in! This can help us get the link updated faster. | ||
| For typos, feel free to include the correction and a screenshot. |
There was a problem hiding this comment.
I like that you give examples for this 😁
| # - label: I have read and accept the [Code of Conduct](https://docs.github.com/articles/github-community-guidelines) | ||
| # required: true |
There was a problem hiding this comment.
Ya, we should probably make one of these, I think this is a pretty standard one that I've seen others use before: https://www.contributor-covenant.org/
There was a problem hiding this comment.
I have them commented out until we have something. That way it is ready to go when we are ready
|
Here are the screenshots so you can see what the forms look like. The table at the top is the meta data Episode Issue
Website Issue
Development Issue
Feature Request
I will look over (and probably implement) all your suggestions. |
There was a problem hiding this comment.
Awesome, thanks for implementing those changes @CGBassPlayer. LGTM 😁
(still going to let @gerbrent review it, but you've got my approval 🥳 )
|
Love all of this!!! Super well thought out and implemented. .....launching! |
|
woooooo!!!
|
Fixes #390
Adds issue templates to help users create issues. Currently the templates are