Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-air alert mockup #34

Closed
reesericci opened this issue Jul 5, 2022 · 15 comments
Closed

On-air alert mockup #34

reesericci opened this issue Jul 5, 2022 · 15 comments
Assignees
@reesericci
Labels
blocked is blocked by another issue/PR design design and visual
Milestone
JB.com 2.0

Comments

@reesericci
Copy link
Collaborator

I made a mockup for what a large item at the top of the page would look like to advertise a currently-live show:

image

--reese
@reesericci
Copy link
Collaborator Author

This could tie into Jbot to update the site whenever !start_show is called

@gerbrent
Copy link
Collaborator

gerbrent commented Jul 5, 2022

great all around!

Maybe then JBot would need some attention...................

@gerbrent gerbrent added the design design and visual label Jul 5, 2022
@reesericci
Copy link
Collaborator Author

There's still some work to be done on it, but it's a good start

@gerbrent gerbrent added the in progress currently being worked on label Jul 12, 2022
@gerbrent gerbrent assigned gerbrent and reesericci and unassigned gerbrent Jul 12, 2022
@gerbrent gerbrent added this to the JB.com 2.0 milestone Jul 27, 2022
@reesericci
Copy link
Collaborator Author

Blocked by #41

@gerbrent gerbrent added the blocked is blocked by another issue/PR label Aug 4, 2022
@reesericci reesericci mentioned this issue Aug 19, 2022
Closed
@reclaimingmytime
Copy link
Contributor

reclaimingmytime commented Aug 22, 2022 •
edited
Loading

@reesericci From #122 (comment):

Could this work for putting an alert on the page

Yes, we could use the JSON API: https://jupiter.tube/api/v1/video-channels/live/videos?isLive=true&skipCount=false&count=1&sort=-createdAt.

The main downside is that the PeerTube API does not know the show name.

However, PreviewPath in the API can be used for the preview image, e.g. https://jupiter.tube/lazy-static/previews/35d4c946-0816-4a3b-b806-3c56ea3d40a0.jpg

An example of the JSON output of when Coder Radio was live 
{
  "total": 1,
  "data": [
    {
      "id": 54,
      "uuid": "9f77b37d-ae21-45ba-bd82-cdb2846aa1a9",
      "shortUUID": "kG81bksrxHN2gx3LKeAmnp",
      "url": "https://jupiter.tube/videos/watch/9f77b37d-ae21-45ba-bd82-cdb2846aa1a9",
      "name": "Coder 480 - It's Microsoft's Move Now",
      "category": {
        "id": 15,
        "label": "Science & Technology"
      },
      "licence": {
        "id": 5,
        "label": "Attribution - Non Commercial - Share Alike"
      },
      "language": {
        "id": "en",
        "label": "English"
      },
      "privacy": {
        "id": 1,
        "label": "Public"
      },
      "nsfw": false,
      "description": "Why it's time to get real about it .Net 7, and why it's Microsoft's moment to make their next move. ",
      "isLocal": true,
      "duration": 0,
      "views": 24,
      "viewers": 14,
      "likes": 0,
      "dislikes": 0,
      "thumbnailPath": "/static/thumbnails/4583aec3-0e15-40ee-958f-4a36b53f2276.jpg",
      "previewPath": "/lazy-static/previews/35d4c946-0816-4a3b-b806-3c56ea3d40a0.jpg",
      "embedPath": "/videos/embed/9f77b37d-ae21-45ba-bd82-cdb2846aa1a9",
      "createdAt": "2022-08-22T15:09:07.309Z",
      "updatedAt": "2022-08-22T16:43:09.287Z",
      "publishedAt": "2022-08-22T15:46:48.577Z",
      "originallyPublishedAt": null,
      "isLive": true,
      "account": {
        "id": 3,
        "displayName": "JBLive Stream",
        "name": "jblive",
        "url": "https://jupiter.tube/accounts/jblive",
        "host": "jupiter.tube",
        "avatars": [
          {
            "width": 48,
            "path": "/lazy-static/avatars/e4d17e7f-a144-4a4a-b5d8-b297b06b727f.png",
            "createdAt": "2022-06-07T23:43:56.565Z",
            "updatedAt": "2022-06-07T23:43:56.565Z"
          },
          {
            "width": 120,
            "path": "/lazy-static/avatars/1340f3e9-d0a7-4bc4-bcbd-a8c865eaf1b8.png",
            "createdAt": "2022-05-30T20:36:19.005Z",
            "updatedAt": "2022-05-30T20:36:19.005Z"
          }
        ],
        "avatar": {
          "width": 48,
          "path": "/lazy-static/avatars/e4d17e7f-a144-4a4a-b5d8-b297b06b727f.png",
          "createdAt": "2022-06-07T23:43:56.565Z",
          "updatedAt": "2022-06-07T23:43:56.565Z"
        }
      },
      "channel": {
        "id": 2,
        "name": "live",
        "displayName": "live",
        "url": "https://jupiter.tube/video-channels/live",
        "host": "jupiter.tube",
        "avatars": [
          {
            "width": 48,
            "path": "/lazy-static/avatars/8acfd2a2-ab4e-48aa-990c-3156a2765d2e.png",
            "createdAt": "2022-06-07T23:43:56.607Z",
            "updatedAt": "2022-06-07T23:43:56.607Z"
          },
          {
            "width": 120,
            "path": "/lazy-static/avatars/e9bcfdb7-90a2-479c-b1da-1ab0e5fc9442.png",
            "createdAt": "2022-05-30T20:38:33.632Z",
            "updatedAt": "2022-05-30T20:38:33.632Z"
          }
        ],
        "avatar": {
          "width": 48,
          "path": "/lazy-static/avatars/8acfd2a2-ab4e-48aa-990c-3156a2765d2e.png",
          "createdAt": "2022-06-07T23:43:56.607Z",
          "updatedAt": "2022-06-07T23:43:56.607Z"
        }
      }
    }
  ]
}

@reesericci
Copy link
Collaborator Author

reesericci commented Aug 22, 2022 via email

@reclaimingmytime
Copy link
Contributor

@reesericci

In the JSON you sent me, data.name exists

True. I guess instead of the show name, we can have the banner mention the entire stream name, e.g. "'Coder 480 - It's Microsoft's Move Now' is currently on the air".

@reesericci
Copy link
Collaborator Author

perfect! Does this make #41 obsolete then?

@reesericci
Copy link
Collaborator Author

@gerbrent

@gerbrent
Copy link
Collaborator

You tell me! Sounds like a good way to go, but you likely have a better judgement of the best approach.

Simplistic, and straightforward via the Peertube API sounds useful and a reasonable way to solve this.

Thoughts?

@reesericci
Copy link
Collaborator Author

I personally like the PeerTube system - but the JBot idea has some benefits. It really depends on how committed JB is to using PeerTube for its live streams vs gammabot/jbot. The JBot would be able to alert the site immediately - so we could set up push notifs, and it's not dependent on peertube.

If anything, the PeerTube system is faster to implement and we can revisit this later. I'm saying go with PeerTube and just get some alert system off the ground.

@reesericci reesericci mentioned this issue Aug 26, 2022
Open
@gerbrent
Copy link
Collaborator

I agree - Peertube is working great so far for our purposes so I think it's here to stay.

JBot is outdated (thus far, as you know) and being potentially replaced by Gammabot.
Gammabot is relatively new, and works fairly well so far but still needs more testing and features (potentially).

Lets do the Peertube option.
If anyone is willing to tackle that, say yay!

@reclaimingmytime
Copy link
Contributor

reclaimingmytime commented Aug 29, 2022 •
edited
Loading

@reesericci Do you have the HTML code of the mockup you made from the screenshot in the first post? That might be useful, so someone working on this feature doesn't have to re-create that alert.

@reesericci
Copy link
Collaborator Author

Unfortunately I don't have it anymore. It was just some inspect code.

@gerbrent
Copy link
Collaborator

feature completed by #378

@reesericci reesericci mentioned this issue Oct 11, 2022
Merged
@gerbrent gerbrent removed the in progress currently being worked on label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reesericci reesericci

Labels
blocked is blocked by another issue/PR design design and visual
Projects
None yet
Milestone
JB.com 2.0
Development

No branches or pull requests
3 participants
@gerbrent @reesericci @reclaimingmytime