Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add more default themes, use bootswatch #338

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented May 23, 2020

the objective of this PR is to add prepared themes and provider nicer way to tweak styles in general.

more details to come in soon


  • provide helper API for syntax highlight theme
  • add build steps to download bootswatch themes
  • add themes
  • maybe use SASS.jl
  • automatic theme matching
  • documentation

@aviatesk aviatesk force-pushed the avi/defaulttheme branch from 5752a76 to 858881e Compare May 23, 2020 11:37
@aviatesk aviatesk mentioned this pull request May 23, 2020
@aviatesk aviatesk force-pushed the avi/defaulttheme branch from 858881e to 7214c3a Compare May 23, 2020 18:12
aviatesk added a commit that referenced this pull request May 23, 2020
@aviatesk aviatesk changed the title wip: add prepared themes wip: style improvement May 23, 2020
@aviatesk aviatesk force-pushed the avi/defaulttheme branch 6 times, most recently from a69ecee to 9e13d0f Compare May 25, 2020 03:23
@aviatesk aviatesk changed the title wip: style improvement wip: add more default themes, use bootswatch May 30, 2020
@aviatesk aviatesk added enhancement HTML documents using HTML labels May 31, 2020
@aviatesk aviatesk added this to the v0.11 milestone May 31, 2020
@aviatesk aviatesk force-pushed the avi/defaulttheme branch 2 times, most recently from fd1493c to 7b48a06 Compare June 2, 2020 11:00
@aviatesk aviatesk force-pushed the avi/defaulttheme branch 2 times, most recently from 0043010 to 657ec58 Compare September 8, 2020 13:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #338 into master will decrease coverage by 0.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   74.23%   73.80%   -0.44%     
==========================================
  Files          25       25              
  Lines        1347     1355       +8     
==========================================
  Hits         1000     1000              
- Misses        347      355       +8     
Flag Coverage Δ
#unittests 73.80% <0.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Weave.jl 50.00% <0.00%> (-0.58%) ⬇️
src/plots.jl 0.00% <ø> (ø)
src/rendering/common.jl 81.52% <0.00%> (-6.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46a0f8b...657ec58. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement HTML documents using HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants