-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument to weave function to disable unicode escape #244
Add argument to weave function to disable unicode escape #244
Conversation
This relies on JuliaDocs/Highlights.jl#30 being merged. |
c53c281
to
da66a8f
Compare
What do you think about renaming |
Good point, will do that. Maybe As the new Highlights.jl seems to be picked up, the escape stuff now works. However, the tests now fail with |
Oh wait, maybe its unrelated to that. I didn't see the failed test at the end. |
Yeah, seems like this is the only relevant error. |
Oh ok. It's the new escaping I added to Highlights. Now |
Hmm, so I have another PR (JuliaDocs/Highlights.jl#38) pending that again changes the escaping behavior. Should I mark the test as broken or skip it and when the Highlights PR is merged, update it? |
That PR doesn't seem to make any changes to the |
You're right, but it changes the escaping of all whitespace chars so the code needs to be fixed anyways. But I will fix it here, so the tests work on master until the PR gets merged. |
After renaming the kw argument its name didn't really match the implementation I had before. That's why I moved the latex unicode escaping stuff to the |
Bump @pfitzseb |
Oops, sorry for the delay. |
uc2tex isn't working very well:
I tried to find a better solution to that (See JuliaDocs/Highlights.jl#30) but thats not very simple and one needs to add a lot of packages to LaTeX.
In my opinion the best way is to use XeLaTeX and try to find a font that is actually able of rendering the unicode chars.
So I added this switch that disables uc2tex (not the default).