Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to override the default values for optimize #37

Closed
wants to merge 1 commit into from
Closed

Allow user to override the default values for optimize #37

wants to merge 1 commit into from

Conversation

DilumAluthge
Copy link
Contributor

This pull request allows the user to override the values of optimize that are passed to Base.code_typed.

@DilumAluthge
Copy link
Contributor Author

Test failures on 1.2 and nightly are a known issue - see issue #31

@pfitzseb pfitzseb closed this Sep 16, 2019
@pfitzseb pfitzseb reopened this Sep 16, 2019
@pfitzseb
Copy link
Member

What's the benefit of this?
I feel like some of our passes won't work correctly with the optimized code_typed (although tests pass, but I wouldn't really want to trust that :P).

@DilumAluthge
Copy link
Contributor Author

So, when I originally opened this PR, I was hoping that I could use it to fix the tests on 1.2. One of the test failures can be fixed by setting optimize = true.

But it didn’t end up panning out for the other test failures, so I don’t think we can use this to fix the tests.

@DilumAluthge DilumAluthge deleted the da/optimize branch September 16, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants