Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to https://github.com/JuliaLang/julia/pull/38791 #371

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Aug 9, 2021

No description provided.

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #371 (0b9a204) into master (b862724) will decrease coverage by 0.24%.
The diff coverage is 20.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   47.77%   47.52%   -0.25%     
==========================================
  Files          43       43              
  Lines        2746     2773      +27     
==========================================
+ Hits         1312     1318       +6     
- Misses       1434     1455      +21     
Flag Coverage Δ
unittests 47.52% <20.68%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules.jl 72.51% <0.00%> (-0.56%) ⬇️
src/repl.jl 5.20% <0.00%> (-0.29%) ⬇️
src/completions.jl 71.49% <35.29%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b862724...0b9a204. Read the comment docs.

@pfitzseb
Copy link
Member

pfitzseb commented Aug 9, 2021

Should come up with a better UX for in-editor completions as well.

@aviatesk
Copy link
Member Author

aviatesk commented Aug 9, 2021

yeah, maybe a dedicated command ?

@pfitzseb
Copy link
Member

pfitzseb commented Aug 9, 2021

Ref https://discourse.julialang.org/t/tab-completion-to-find-methods-for-given-variable-s/66076 :)

@aviatesk aviatesk merged commit dc60387 into master Aug 9, 2021
@aviatesk aviatesk deleted the avi/update branch August 9, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants