Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip preceding ! operator #358

Merged
merged 2 commits into from
Nov 18, 2020
Merged

strip preceding ! operator #358

merged 2 commits into from
Nov 18, 2020

Conversation

aviatesk
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #358 (9af4b6b) into master (1f854cd) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   55.84%   55.66%   -0.18%     
==========================================
  Files          43       43              
  Lines        2688     2673      -15     
==========================================
- Hits         1501     1488      -13     
+ Misses       1187     1185       -2     
Flag Coverage Δ
unittests 55.66% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/eval.jl 59.13% <100.00%> (-0.65%) ⬇️
src/goto.jl 89.30% <100.00%> (+6.61%) ⬆️
src/Atom.jl 88.88% <0.00%> (-11.12%) ⬇️
src/datatip.jl 67.74% <0.00%> (-6.51%) ⬇️
src/outline.jl 64.00% <0.00%> (-4.97%) ⬇️
src/display/errors.jl 35.41% <0.00%> (-2.09%) ⬇️
src/docs.jl 72.72% <0.00%> (-1.82%) ⬇️
src/static/local.jl 94.11% <0.00%> (-1.48%) ⬇️
src/utils.jl 88.65% <0.00%> (-1.14%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f854cd...9af4b6b. Read the comment docs.

…nding entry for a given file path

this can happen for `Main` module, or when an user manually changes a 
module
@aviatesk aviatesk merged commit b21f12c into master Nov 18, 2020
@aviatesk aviatesk deleted the avi/!op branch November 18, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants