Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix function display on v1.6 #339

Merged
merged 3 commits into from
Jul 6, 2020
Merged

fix function display on v1.6 #339

merged 3 commits into from
Jul 6, 2020

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Jul 5, 2020

I found string(typeof(f).name) returns "typename(typeof(f))", which causes function display a bit weird (e.g. sin() on v1.6 (at least current master)

I believe using repr and string would make the logic mach simpler and robust in the future, so this PR.

I also improved a logic in a completion a bit

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #339 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   55.63%   55.54%   -0.10%     
==========================================
  Files          43       43              
  Lines        2644     2634      -10     
==========================================
- Hits         1471     1463       -8     
+ Misses       1173     1171       -2     
Flag Coverage Δ
#unittests 55.54% <100.00%> (-0.10%) ⬇️
Impacted Files Coverage Δ
src/completions.jl 78.77% <100.00%> (+0.39%) ⬆️
src/display/base.jl 37.09% <100.00%> (-3.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f43a59...e93747f. Read the comment docs.

@aviatesk aviatesk merged commit ce6a810 into master Jul 6, 2020
@aviatesk aviatesk deleted the avi/fixdisplay branch July 6, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant