Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit refactors #334

Merged
merged 2 commits into from
May 19, 2020
Merged

bit refactors #334

merged 2 commits into from
May 19, 2020

Conversation

aviatesk
Copy link
Member

  • ::Int -> ::Integer for 32bits system compatibility
  • don't overload Base.contlines

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #334 into master will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   57.48%   57.48%           
=======================================
  Files          43       43           
  Lines        2531     2531           
=======================================
  Hits         1455     1455           
  Misses       1076     1076           
Flag Coverage Δ
#unittests 57.48% <80.00%> (ø)
Impacted Files Coverage Δ
src/datatip.jl 77.77% <0.00%> (ø)
src/utils.jl 89.24% <ø> (ø)
src/static/static.jl 91.13% <50.00%> (ø)
src/display/base.jl 43.54% <100.00%> (ø)
src/static/local.jl 100.00% <100.00%> (ø)
src/static/toplevel.jl 94.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbea229...0625bda. Read the comment docs.

aviatesk added 2 commits May 19, 2020 15:38
- will get rid of possible method errors in 32bits system
@aviatesk aviatesk merged commit b9afde9 into master May 19, 2020
@aviatesk aviatesk deleted the avi/int branch May 19, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant