Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve evalsimple handler: #333

Merged
merged 3 commits into from
May 18, 2020
Merged

improve evalsimple handler: #333

merged 3 commits into from
May 18, 2020

Conversation

aviatesk
Copy link
Member

  • use JunoProgressLogger
  • use include_string

- use `JunoProgressLogger`
- use `include_string`
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #333 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   57.47%   57.48%   +0.01%     
==========================================
  Files          43       43              
  Lines        2530     2531       +1     
==========================================
+ Hits         1454     1455       +1     
  Misses       1076     1076              
Flag Coverage Δ
#unittests 57.48% <100.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
src/misc.jl 22.22% <100.00%> (+4.57%) ⬆️
src/precompile.jl 98.59% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0fdf3...bb79706. Read the comment docs.

@pfitzseb pfitzseb closed this May 18, 2020
@pfitzseb pfitzseb reopened this May 18, 2020
@pfitzseb pfitzseb merged commit 4f44beb into master May 18, 2020
@aviatesk aviatesk deleted the avi/evalsimple branch May 18, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants