Matching Windows paths with spaces #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JunoLab/Juno.jl#421 to correctly handle Windows paths with spaces in Juno REPL. Also added some tests.
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 54.95% 54.95%
=======================================
Files 42 42
Lines 2615 2615
=======================================
Hits 1437 1437
Misses 1178 1178
Continue to review full report at Codecov.
|
Updated the regexp to better handle file extensions by excluding non-path characters.
FAlobaid
added a commit
to FAlobaid/Atom.jl
that referenced
this pull request
Apr 16, 2020
This fix is related to JunoLab/Juno.jl#421 and improves on the previous PR JunoLab#320 to better handle paths with spaces in Juno REPL for Windows, macOS and Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JunoLab/Juno.jl#421 to correctly handle Windows paths with spaces in Juno REPL. Also added some tests. Related pull request: JunoLab/atom-julia-client#731.