Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GitHub Actions: #319

Merged
merged 2 commits into from
Apr 14, 2020
Merged

use GitHub Actions: #319

merged 2 commits into from
Apr 14, 2020

Conversation

aviatesk
Copy link
Member

  • test on all the platforms, machine architecture, with the power of Azure in the back
  • fix test on 32bit system
  • skip test of realpath issue in macOS with v1.0

@aviatesk aviatesk force-pushed the avi/actions branch 2 times, most recently from 2f6f022 to 8aea9c3 Compare April 12, 2020 05:30
- test on all the platforms, machine achitecture, with the power of 
Azure
- fix test on 32bit system
- skip test of `realpath` issue in macOS with v1.0
@aviatesk
Copy link
Member Author

aviatesk commented Apr 12, 2020

So Azure's concurrent task ability allows us to finish those 15 tests in ~8mins, while with travis we have to wait ~30 mins until all the tests get finished iirc.
Right now I couldn't setup codecov report correctly though. The results are uploaded to codecov server, but uploading the coverage results into PR comment fails with the following error:

RROR: HTTP.ExceptionRequest.StatusError(400, "POST", "/upload/v2?&service=custom&commit=b13caf048447000a4411eceea923c158703ff673&slug=JunoLab/Atom.jl&token=", HTTP.Messages.Response:
"""
HTTP/1.1 400 Bad Request
Server: nginx/1.13.12
Date: Sun, 12 Apr 2020 05:44:43 GMT
Content-Type: text/html; charset=UTF-8
Content-Length: 32867
Connection: keep-alive
X-Xss-Protection: 1; mode=block
Content-Security-Policy: default-src 

EDIT: that seems to have been fixed by using julia-actions/julia-processcoverage@v1

@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #319 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   54.76%   54.95%   +0.19%     
==========================================
  Files          42       42              
  Lines        2615     2615              
==========================================
+ Hits         1432     1437       +5     
+ Misses       1183     1178       -5     
Flag Coverage Δ
#unittests 54.95% <ø> (?)
Impacted Files Coverage Δ
src/goto.jl 84.56% <0.00%> (-0.68%) ⬇️
src/utils.jl 87.77% <0.00%> (+1.11%) ⬆️
src/completions.jl 76.79% <0.00%> (+2.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb13a3b...e1c82c6. Read the comment docs.

@aviatesk aviatesk merged commit f4d3140 into master Apr 14, 2020
@aviatesk aviatesk deleted the avi/actions branch April 14, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant