lazy Traceur loading #309
Merged
lazy Traceur loading #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
commented
Apr 3, 2020
| Requires.@require WebIO="0f1e0344-ec1d-5b48-a673-e5cf874b6c29" begin | ||
| include("display/webio.jl") | ||
| end | ||
| @require WebIO="0f1e0344-ec1d-5b48-a673-e5cf874b6c29" include("display/webio.jl") |
There was a problem hiding this comment.
I'm not sure why webio.jl is better to be loaded by @require. Maybe because building WebIO sometimes fails ?
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 54.92% 54.83% -0.09%
==========================================
Files 42 42
Lines 2933 3007 +74
==========================================
+ Hits 1611 1649 +38
- Misses 1322 1358 +36
Continue to review full report at Codecov.
|
|
@pfitzseb maybe are you against this ? |
|
No, I just forgot about this. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Traceur is still in alpha (and currently has problems in its performance and robustness), I believe ppl don't use this integration so much that it might be okay that it's not provided by default.
Although Traceur (and Cassette) dependency isn't so heavy, but will improve the loading time for sure.