Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error printing #195

Merged
merged 1 commit into from
Oct 7, 2019
Merged

improve error printing #195

merged 1 commit into from
Oct 7, 2019

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Oct 7, 2019

and add an option to always show errors in REPL when using inline evaluation.

Fixes JunoLab/Juno.jl#381.

and add an option to always show errors in REPL when using inline 
evaluation
@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #195 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   28.53%   28.49%   -0.04%     
==========================================
  Files          35       35              
  Lines        1514     1516       +2     
==========================================
  Hits          432      432              
- Misses       1082     1084       +2
Impacted Files Coverage Δ
src/eval.jl 18.68% <0%> (+0.2%) ⬆️
src/display/errors.jl 37.5% <0%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3ed71...fd1a69a. Read the comment docs.

src/eval.jl Show resolved Hide resolved
@pfitzseb pfitzseb merged commit 61f9655 into master Oct 7, 2019
@pfitzseb pfitzseb deleted the sp/bettererrors branch October 7, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Print errors in console for in-line evaluation
2 participants