Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow #193 #194

Merged
merged 2 commits into from
Oct 8, 2019
Merged

follow #193 #194

merged 2 commits into from
Oct 8, 2019

Conversation

aviatesk
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #194 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #194     +/-   ##
=========================================
+ Coverage   39.21%   39.41%   +0.2%     
=========================================
  Files          36       36             
  Lines        1808     1814      +6     
=========================================
+ Hits          709      715      +6     
  Misses       1099     1099
Impacted Files Coverage Δ
src/utils.jl 95.36% <100%> (+0.19%) ⬆️
src/completions.jl 76.99% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6054c5...92c040c. Read the comment docs.

@pfitzseb
Copy link
Member

pfitzseb commented Oct 7, 2019

Can you rebase this?

@aviatesk
Copy link
Member Author

aviatesk commented Oct 7, 2019

of course.
How about the actual PR itself ?

@pfitzseb pfitzseb merged commit d1622f4 into master Oct 8, 2019
@pfitzseb pfitzseb deleted the avi/follow193 branch January 7, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants