Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refactors: #168

Merged
merged 1 commit into from
Sep 9, 2019
Merged

small refactors: #168

merged 1 commit into from
Sep 9, 2019

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Sep 6, 2019

  • remove unnecessary field from DebuggerState
  • type structs in outline.jl
  • more const
  • remove union type from makedescription

neither of them is slow for now, thus the changes above wouldn't be any important tho.

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #168 into master will increase coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   27.47%   27.54%   +0.06%     
==========================================
  Files          32       32              
  Lines        1452     1452              
==========================================
+ Hits          399      400       +1     
+ Misses       1053     1052       -1
Impacted Files Coverage Δ
src/frontend.jl 0% <ø> (ø) ⬆️
src/path_matching.jl 84.61% <ø> (ø) ⬆️
src/completions.jl 84% <100%> (+0.12%) ⬆️
src/outline.jl 87.62% <100%> (ø) ⬆️
src/debugger/stepper.jl 1.22% <25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95112e...71d7b96. Read the comment docs.

- remove unnecessary field from DebuggerState
- type structs in outline.jl
- more const
- remove union type from `makedescription`
@pfitzseb pfitzseb merged commit da604f8 into master Sep 9, 2019
@pfitzseb pfitzseb deleted the avi/type-tips branch September 9, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants