Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escaped $ Bourne-style shell prompt support #868

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

mmellin
Copy link
Contributor

@mmellin mmellin commented Aug 22, 2018

This pull request adds proper support by escaping the $ character within the shell prompt variables. This avoids errors when running under normal CLI prompt conditions.

vnitinv and others added 2 commits August 22, 2018 10:28
Changes to handle newer junos devices

Update Shell prompts string patterns with  for bourne-style shell
@jnpr-community-netdev
Copy link

Can one of the admins verify this patch?

…ell(). This customization helps stabilize the data received from the Parammiko channel during loops of run().
@mmellin
Copy link
Contributor Author

mmellin commented Aug 22, 2018

I guess I didn't create a new branch to split these commit into. Sorry.

Commit fcecf2e is an update to fix an issue with adding the $ prompt. This character seems to need escaping in order for the code to work properly under all conditions.

Commit a9a9c57 is in response to issue #869

@jnpr-community-netdev
Copy link

Can one of the admins verify this patch?

@dineshbaburam91
Copy link
Collaborator

Fixed using #882 and #934.
Kindly let us know why you required "sleep" in wait_for() definition?

@ntwrkguru
Copy link
Contributor

@dineshbaburam91 The reason for the sleep was literally in the code:

        :param seconds sleep:
           Time to wait after initial call to receive data from buffer. This
           value can help stabilize the output when multiple calls to run()
           are looped but will increase the time spent receiving output.  This
           value can be a floating point number for subsecond precision.

@rahkumar651991 rahkumar651991 self-assigned this Sep 15, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 93.639% when pulling 83ecfde on mmellin:master into b96f116 on Juniper:master.

@coveralls
Copy link

coveralls commented Sep 16, 2021

Coverage Status

Coverage decreased (-0.02%) to 93.635% when pulling 83ecfde on mmellin:master into b96f116 on Juniper:master.

@rahkumar651991 rahkumar651991 merged commit 5583ff7 into Juniper:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants