Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #1322 to pass no_validate #1323

Conversation

chidanandpujar
Copy link
Collaborator

sw.install parameter validate=False is not passed on to the NSSU and ISSU upgrade .
Added code to set no_validate option when validate=False

@@ -984,11 +984,17 @@ def _progress(report):
kwargs.update({"no_validate": True})

if issu is True:
if validate is False:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you explicitly setting the validate option as True always?

Are there any reference document , validation always be "True" in case of ISSU and NSSU

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we set the option validate=False, we are not passing on this option to request system software add/request system software nonstop-upgrade/request system software add.

no-validate
(Optional) When loading a software package or bundle with a different release, suppress the default behavior of the validate option.

validate
(Optional) Validate the software package or bundle against the current configuration as a prerequisite to adding the software package or bundle. This is the default behavior when the software package or bundle being added is a different release.

no-validate
(Optional) Starting in Junos OS Release 20.4R2, skip the validation step of the unified ISSU process.

@chidanandpujar
Copy link
Collaborator Author

Issue is taken care in the pull request #1334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants