Enhanced - Handle the error status returned by platform APIs #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there is an error returned by platform API - Translate the error bitmap to error description for generic errors - Fetch the error description from sfp_error dict or via calling platform API get_error_description for vendor specific errors - Adjust unit test cases Signed-off-by: Stephen Sun <[email protected]>
| if error in status_dict['error']: | ||
| return True | ||
| error = status_dict.get('error') | ||
| if SfpBase.SFP_ERROR_DESCRIPTION_BLOCKING in error: |
There was a problem hiding this comment.
return SfpBase.SFP_ERROR_DESCRIPTION_BLOCKING in error
Signed-off-by: Stephen Sun <[email protected]>
Junchao-Mellanox
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there is an error returned by platform API
Signed-off-by: Stephen Sun [email protected]
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)