Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4 Hotfix + Bug fixes and cleanup #6

Merged
merged 10 commits into from
Apr 15, 2023
Merged

Godot 4 Hotfix + Bug fixes and cleanup #6

merged 10 commits into from
Apr 15, 2023

Conversation

ZachAR3
Copy link
Contributor

@ZachAR3 ZachAR3 commented Apr 9, 2023

Running on Godot 4.0.2 there are a few issues present resulting in an inability to use this plugin. This PR aims to resolve those by changing a few names and type script, along with rewriting the tweens to work with the new system. WARNING due to sub-optimal physics in Godot 4 at the moment, the explosion script acts sporadically, and the piles of rigidbodies twitch far more then in Godot 3. This will hopefully be fixed in a future patch, but for the time being the explosion likely needs some parameter changes. I may work on those once I have more free-time if no one has done so already.

@Jummit
Copy link
Owner

Jummit commented Apr 11, 2023

Thanks for taking the time! I think the best course of action would be to get the 4.0 version of the plugin to be stable and then release it as the main version.

@ZachAR3
Copy link
Contributor Author

ZachAR3 commented Apr 11, 2023

Fair enough, I would still merge this with master since currently master is unusable other than on old 4.0 betas; but I understand waiting to re-release it on the market place. Any pressing issues preventing the release on the market I can take a look at?

@ZachAR3
Copy link
Contributor Author

ZachAR3 commented Apr 11, 2023

Thanks for taking the time! I think the best course of action would be to get the 4.0 version of the plugin to be stable and then release it as the main version.

It also seems the issue I was experiencing with the rigid body seems to be an issue with the position property of impulse on the first tick of the rigid body. I opened an issue request here, hopefully it will be fixed soon so the work around can be removed.

ZachAR3 added 3 commits April 11, 2023 17:32
…eeded; and scaled down velocity to reduce explosion size to be more similar to in Godot 3.x
…would remain orphaned after the destructible was freed. Caused massive lag after only a few shards.
@ZachAR3 ZachAR3 changed the title Godot 4 Hotfix Godot 4 Hotfix + Bug fixes and cleanup Apr 11, 2023
@Jummit
Copy link
Owner

Jummit commented Apr 15, 2023

Merging, but I might push some changes after I look over this in detail.

@Jummit Jummit merged commit 1b6de72 into Jummit:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants