Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Error rework #21

Closed
wants to merge 13 commits into from
Closed

Read Error rework #21

wants to merge 13 commits into from

Conversation

JulianSchmid
Copy link
Owner

Resolves #16

@JulianSchmid JulianSchmid added this to the v0.11 milestone Dec 26, 2021
@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #21 (2323e4c) into master (82e959c) will decrease coverage by 0.16%.
The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   99.68%   99.52%   -0.17%     
==========================================
  Files          45       48       +3     
  Lines       16428    18237    +1809     
==========================================
+ Hits        16377    18150    +1773     
- Misses         51       87      +36     
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (+0.45%) ⬆️
tests/internet/ip.rs 99.51% <ø> (ø)
tests/packet_decoder/mod.rs 100.00% <ø> (ø)
tests/packet_slicing/mod.rs 98.37% <ø> (ø)
tests/de/mod.rs 97.16% <97.16%> (ø)
tests/errors/mod.rs 98.80% <98.93%> (-0.03%) ⬇️
src/errors.rs 99.39% <99.39%> (ø)
src/de.rs 100.00% <100.00%> (ø)
src/internet/ip.rs 100.00% <100.00%> (ø)
src/internet/ip_authentication.rs 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e959c...2323e4c. Read the comment docs.

@JulianSchmid JulianSchmid changed the title Error rework Read Error rework Jan 2, 2022
@JulianSchmid JulianSchmid modified the milestones: v0.11, v0.12 Jul 2, 2022
@JulianSchmid JulianSchmid modified the milestones: v0.12, v0.13 Jul 24, 2022
@JulianSchmid JulianSchmid modified the milestones: v0.13, v0.15 Dec 17, 2022
@JulianSchmid
Copy link
Owner Author

https://github.com/JulianSchmid/etherparse/releases/tag/v0.14.0 implemented a better version of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More specific error types
1 participant