Resolved cippy warnings

etherparse/src/err/packet/build_write_error.rs

@@ -65,10 +65,7 @@ impl BuildWriteError {
 
     /// Returns true if the `BuildWriteError` is a `Icmpv6InIpv4`.
     pub fn is_icmpv6_in_ipv4(&self) -> bool {
-        match self {
-            BuildWriteError::Icmpv6InIpv4 => true,
-            _ => false,
-        }
+        matches!(self, BuildWriteError::Icmpv6InIpv4)
     }
 }
 

etherparse/src/internet/ip_number_impl.rs

@@ -737,12 +737,10 @@ impl core::fmt::Debug for IpNumber {
             } else {
                 write!(f, "{} ({})", self.0, keyword)
             }
+        } else if let Some(protocol) = self.protocol_str() {
+            write!(f, "{} ({})", self.0, protocol)
         } else {
-            if let Some(protocol) = self.protocol_str() {
-                write!(f, "{} ({})", self.0, protocol)
-            } else {
-                write!(f, "{}", self.0)
-            }
+            write!(f, "{}", self.0)
         }
     }
 }

etherparse/src/internet/ipv4_header.rs

@@ -473,7 +473,7 @@ impl Ipv4Header {
             options: {
                 let mut options = Ipv4Options::new();
                 options.len = (ihl - 5) * 4;
-                if options.len() > 0 {
+                if false == options.is_empty() {
                     reader.read_exact(options.as_mut()).map_err(Io)?;
                 }
                 options

etherparse/src/internet/ipv4_options.rs

@@ -70,6 +70,12 @@ impl Ipv4Options {
     pub fn len(&self) -> u8 {
         self.len
     }
+
+    /// Returns if the length of the options is zero.
+    #[inline]
+    pub fn is_empty(&self) -> bool {
+        self.len == 0
+    }
 }
 
 impl TryFrom<&[u8]> for Ipv4Options {
@@ -253,6 +259,18 @@ mod tests {
         assert_eq!(actual.buf, [0; 40]);
     }
 
+    #[test]
+    fn is_empty() {
+        {
+            let actual = Ipv4Options::new();
+            assert!(actual.is_empty());
+        }
+        {
+            let actual: Ipv4Options = [1, 2, 3, 4].into();
+            assert_eq!(false, actual.is_empty());
+        }
+    }
+
     #[test]
     fn try_from() {
         const DATA: [u8; 48] = [

etherparse/src/internet/ipv6_flow_label.rs

@@ -56,7 +56,7 @@ impl Ipv6FlowLabel {
     pub const ZERO: Ipv6FlowLabel = Ipv6FlowLabel(0);
 
     /// Maximum value of an IPv6 Flow Label.
-    pub const MAX_U32: u32 = 0b1111_11111111_11111111;
+    pub const MAX_U32: u32 = 0b1111_1111_1111_1111_1111;
 
     /// Tries to create an [`Ipv6FlowLabel`] and checks that the passed value
     /// is smaller or equal than [`Ipv6FlowLabel::MAX_U32`] (20 bit unsigned integer).

etherparse/src/internet/ipv6_fragment_header.rs

@@ -105,7 +105,7 @@ impl Ipv6FragmentHeader {
     /// Writes a given IPv6 fragment header to the current position.
     #[cfg(feature = "std")]
     pub fn write<T: std::io::Write + Sized>(&self, writer: &mut T) -> Result<(), std::io::Error> {
-        Ok(writer.write_all(&self.to_bytes())?)
+        writer.write_all(&self.to_bytes())
     }
 
     /// Length of the header in bytes.

etherparse/src/internet/ipv6_raw_ext_header.rs

@@ -229,7 +229,7 @@ impl Ipv6RawExtHeader {
 #[cfg(test)]
 mod test {
     use super::*;
-    use crate::{test_gens::*, *};
+    use crate::test_gens::*;
     use alloc::{format, vec::Vec};
     use proptest::prelude::*;
     use std::io::Cursor;

etherparse/src/transport/tcp_header.rs

@@ -570,7 +570,7 @@ impl TcpHeader {
                 .add_4bytes(source_ip)
                 .add_4bytes(destination_ip)
                 .add_2bytes([0, ip_number::TCP.0])
-                .add_2bytes((tcp_len as u16).to_be_bytes()),
+                .add_2bytes(tcp_len.to_be_bytes()),
             payload,
         ))
     }
@@ -606,7 +606,7 @@ impl TcpHeader {
             checksum::Sum16BitWords::new()
                 .add_16bytes(source)
                 .add_16bytes(destination)
-                .add_4bytes((tcp_len as u32).to_be_bytes())
+                .add_4bytes(tcp_len.to_be_bytes())
                 .add_2bytes([0, ip_number::TCP.0]),
             payload,
         ))

etherparse_proptest_generators/src/lib.rs

@@ -59,7 +59,7 @@ prop_compose! {
 
 prop_compose! {
     pub fn ipv6_flow_label_any()
-        (value in 0u32..=0b1111_11111111_11111111u32)
+        (value in 0u32..=0b1111_1111_1111_1111_1111_u32)
         -> Ipv6FlowLabel
     {
         Ipv6FlowLabel::try_new(value).unwrap()