AssetRegistry #55
Merged
AssetRegistry #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by: Ranjan Anantharaman <[email protected]> Co-authored by: Shashi Gowda <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
+ Coverage 54.86% 55.17% +0.3%
=========================================
Files 7 7
Lines 113 116 +3
=========================================
+ Hits 62 64 +2
- Misses 51 52 +1
Continue to review full report at Codecov.
|
|
I think we have to change the README also? Or at least say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a common package which holds a key -> path dictionary of files to serve by default in Mux.
Packages interested in serving static files can register with this base package without depending on Mux.