Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly pass depot path during tests #85

Merged
merged 1 commit into from
Mar 5, 2020
Merged

explicitly pass depot path during tests #85

merged 1 commit into from
Mar 5, 2020

Conversation

tanmaykm
Copy link
Member

@tanmaykm tanmaykm commented Mar 4, 2020

Depot path needs to be passed explicitly in tests to handle environments where they are set differently.

@tanmaykm
explicitly pass depot path during tests
a754c7e 
Depot path needs to be passed explicitly in tests to handle environments where they are set differently.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.385% when pulling a754c7e on tan/misc into 3ced623 on master.

@tanmaykm tanmaykm merged commit 2337f21 into master Mar 5, 2020
tanmaykm added a commit that referenced this pull request Mar 5, 2020
@tanmaykm
do not use startup files in tests
d53dd11 
do not use startup files too in tests, for the same reasons as mentioned in #85
@tanmaykm tanmaykm mentioned this pull request Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanmaykm @coveralls