Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_private and is_global #20

Merged
merged 2 commits into from
Jul 1, 2021
Merged

is_private and is_global #20

merged 2 commits into from
Jul 1, 2021

Conversation

fredrikekre
Copy link
Member

Add is_private and is_global for classification of IP addresses.

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #20 (6c65c3e) into master (9f9befc) will decrease coverage by 1.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #20      +/-   ##
===========================================
- Coverage   100.00%   98.43%   -1.57%     
===========================================
  Files            1        1              
  Lines           61       64       +3     
===========================================
+ Hits            61       63       +2     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/IPNets.jl 98.43% <100.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9befc...6c65c3e. Read the comment docs.

@fredrikekre
Copy link
Member Author

(Sorry for the "mass review request". The repo requires approvals so I can not merge it without it :) )

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also invited you to JuliaWeb admin team

@fredrikekre fredrikekre merged commit 92a9364 into master Jul 1, 2021
@fredrikekre fredrikekre deleted the fe/private branch July 1, 2021 15:22
@fredrikekre
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants