Revert "When monitoring idle connections, only call eof on tcp socket" #914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #912
The problem here is that when we go to reuse connections later, the ssl layer hasn't had time (or been told by
monitor_idle_connections
) to process encrypted data and potential close notify records. This can be bad if you, for example, do a bunch of simultaneous requests which build up a bunch of MbedTLS.SSLContext connections in the connection pool, then go to try and do a request later and all the connections are actually closed, even though they haven't been properly closed at the ssl layer.