Cleanup all timeout code and places where we might timeout #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #909. Great issue that stretches our current system and exposes a bunch of places where we weren't accounting for timeouts. The core issues here are when we have a proxy involved, we had a couple more places where we were connecting/writing/reading, but weren't applying a user-provided `connect_timeout` or `readtimeout`. Also for our ssl upgrade path. In the OP's example, we're hitting thousands of mostly non-functional proxies, so it's basically a huge stress test on all the error paths of our request code. This PR proposes: * a new `try_with_timeout` function to provide a consistent way to run code while waiting for a timeout * use the new function in a number of places where we might be stuck waiting I'm able to get the original script OP provided to finish in ~150 seconds, and I tried out a multithreaded version that finished in about ~17 seconds w/ 8 threads.
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
==========================================
+ Coverage 80.15% 80.20% +0.04%
==========================================
Files 36 36
Lines 2908 2915 +7
==========================================
+ Hits 2331 2338 +7
Misses 577 577
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #909. Great issue that stretches our current system and exposes
a bunch of places where we weren't accounting for timeouts. The core
issues here are when we have a proxy involved, we had a couple more
places where we were connecting/writing/reading, but weren't applying
a user-provided
connect_timeoutorreadtimeout. Also for ourssl upgrade path. In the OP's example, we're hitting thousands of mostly
non-functional proxies, so it's basically a huge stress test on all the
error paths of our request code. This PR proposes:
try_with_timeoutfunction to provide a consistent way to runcode while waiting for a timeout
I'm able to get the original script OP provided to finish in ~150 seconds, and
I tried out a multithreaded version that finished in about ~17 seconds w/ 8 threads.