Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for new users about precompile problems. #88

Closed
wants to merge 1 commit into from

Conversation

samoconnor
Copy link
Contributor

Hi @quinnj,

It might be a good idea to say something on README.md about the start-up delay.
For some of my HTTP.jl use-cases it's a show-stopper, but for others, it makes no difference at all because there are other packages that already take a long time to start up.

@codecov-io
Copy link

codecov-io commented Sep 1, 2017

Codecov Report

Merging #88 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   65.82%   65.93%   +0.11%     
==========================================
  Files          14       14              
  Lines        2876     2874       -2     
==========================================
+ Hits         1893     1895       +2     
+ Misses        983      979       -4
Impacted Files Coverage Δ
src/parser.jl 71.1% <0%> (+0.08%) ⬆️
src/urlparser.jl 78.04% <0%> (+0.37%) ⬆️
src/uri.jl 64.28% <0%> (+0.56%) ⬆️
src/sniff.jl 69.09% <0%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd5746...49953cc. Read the comment docs.

@quinnj quinnj closed this Oct 13, 2017
@quinnj
Copy link
Member

quinnj commented Oct 13, 2017

Just pushed fixes for precompiles; I think we're in good shape now, definitely useable in normal applications. Things will improve further once we're able to precompile things for other modules (ref here).

@samoconnor
Copy link
Contributor Author

See performance comparison note: #58 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants