Don't write headers if value is empty #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #828. This follows a convention curl uses where empty headers aren't included when the request is sent. Pretty minimal changes here which is nice that this is so easy to support.
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 78.56% 77.50% -1.07%
==========================================
Files 36 36
Lines 2538 2538
==========================================
- Hits 1994 1967 -27
- Misses 544 571 +27
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #828. This follows a convention curl uses where empty headers
aren't included when the request is sent. Pretty minimal changes here
which is nice that this is so easy to support.