Refine how redirect method is set #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #825. TIL: not all redirects should use the same method as the original request, and in fact, most http client implementations will default the new request method to GET. I included links to a few useful discussions/references, but essentially the behavior we now support is: * For 307/308 response status, use original request method; these statuses are specifically for indicating the original method is ok * For 303 response status, must use GET method * For other 3xx responses, it's actually legal to use the original method, but most client implementations will switch to GET, which means most servers have adapted to expect this and may even error if the original request method is used (as is the case in the originally reported issue). We now follow this behavior, though, like curl, allow overriding this behavior by a new `redirect_method` keyword arg to allow specifying the redirect method behavior.
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
==========================================
- Coverage 78.65% 78.48% -0.17%
==========================================
Files 36 36
Lines 2506 2524 +18
==========================================
+ Hits 1971 1981 +10
- Misses 535 543 +8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #825. TIL: not all redirects should use the same method as
the original request, and in fact, most http client implementations
will default the new request method to GET. I included links to
a few useful discussions/references, but essentially the behavior
we now support is:
statuses are specifically for indicating the original method is ok
method, but most client implementations will switch to GET,
which means most servers have adapted to expect this and may even
error if the original request method is used (as is the case in
the originally reported issue). We now follow this behavior, though,
like curl, allow overriding this behavior by a new
redirect_methodkeyword arg to allow specifying the redirect method behavior.