Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTTP.header default to be anything #820

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Conversation

omus
Copy link
Contributor

@omus omus commented Apr 8, 2022

I wanted to be able to set the default to nothing to be able to distinguish from header which is set to the empty string.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #820 (134eaee) into master (2cec06e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   78.77%   78.77%           
=======================================
  Files          36       36           
  Lines        2502     2502           
=======================================
  Hits         1971     1971           
  Misses        531      531           
Impacted Files Coverage Δ
src/Messages.jl 86.52% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM; note we currently have a stack of breaking changes on master; so if this is needed in a sooner release, you could propose a branch off the lastest 0.9.X release. I'm hoping to get the breaking release out in the next month or so.

@quinnj quinnj merged commit ee1a838 into master Apr 9, 2022
@quinnj quinnj deleted the cv/header-default branch April 9, 2022 17:11
@omus
Copy link
Contributor Author

omus commented Apr 11, 2022

SGTM; note we currently have a stack of breaking changes on master; so if this is needed in a sooner release, you could propose a branch off the lastest 0.9.X release. I'm hoping to get the breaking release out in the next month or so.

I'm not in a rush. This has been a minor annoyance and it's good to just know it will be addressed in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants