-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Do not call close..." and release 0.9.16 #773
Conversation
This reverts commit 03749a4.
ae60b34
to
3621089
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this.
To be clear I think it is entirely possible that #752 is the correct thing to do.
But I think we would like have a bit more time to think about it,
and reverting it and tagging a patch gives us that time.
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 77.46% 77.47%
=======================================
Files 38 38
Lines 2561 2562 +1
=======================================
+ Hits 1984 1985 +1
Misses 577 577
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with reverting this change as long as we create an issue for removing close
as part of a breaking release and mention it in the change logs.
That is one possibility, but let's take the time to discuss it and think it through fully. |
Basically I want to make that issue now |
3621089
to
3e17e94
Compare
This is fine by me in terms of keeping the stable releases going. I still think the original patch was the correct approach, so I'll propose it again as a PR, and we can mark it breaking, and decide when to merge it. |
See #775 |
Since #752 turned out to be rather breaking I propose a new release with that change reverted. We should also yank 0.9.15 from the registry.
Fixes #772
cc @oxinabox @mattBrzezinski @nickrobinson251 @c42f @quinnj @omus