Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat set-cookie header as case insensitive #766

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Treat set-cookie header as case insensitive #766

merged 1 commit into from
Sep 26, 2021

Conversation

RuiRojo
Copy link
Contributor

@RuiRojo RuiRojo commented Sep 24, 2021

Fix #765

@RuiRojo RuiRojo mentioned this pull request Sep 24, 2021
Closed
quinnj
quinnj reviewed Sep 24, 2021
View reviewed changes
src/CookieRequest.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021 •
edited
Loading

Codecov Report

Merging #766 (b41b9c4) into master (f5957aa) will decrease coverage by 0.69%.
The diff coverage is 100.00%.

❗ Current head b41b9c4 differs from pull request most recent head b701515. Consider uploading reports for the commit b701515 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
- Coverage   77.46%   76.76%   -0.70%     
==========================================
  Files          38       38              
  Lines        2560     2557       -3     
==========================================
- Hits         1983     1963      -20     
- Misses        577      594      +17
Impacted Files Coverage Δ
src/CookieRequest.jl 85.29% <100.00%> (ø)
src/HTTP.jl 76.59% <0.00%> (-21.28%) ⬇️
src/WebSockets.jl 85.80% <0.00%> (-4.52%) ⬇️
src/ConnectionPool.jl 80.71% <0.00%> (-0.90%) ⬇️
src/Servers.jl 85.97% <0.00%> (ø)
src/Handlers.jl 62.65% <0.00%> (ø)
src/download.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5957aa...b701515. Read the comment docs.

@fredrikekre
Copy link
Member

Possible to add a test?

@RuiRojo @quinnj @fredrikekre
Make Set-Cookie response header case insensitive, fixes #765.
b701515 
Co-authored-by: Rui Rojo <[email protected]>
Co-authored-by: Jacob Quinn <[email protected]>
Co-authored-by: Fredrik Ekre <[email protected]>
@fredrikekre fredrikekre merged commit 0da6e2a into JuliaWeb:master Sep 26, 2021
@RuiRojo RuiRojo deleted the fix-setcookie-case branch September 26, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cookies not saved because case-sensitive Set-Cookie header?
4 participants
@RuiRojo @codecov-commenter @fredrikekre @quinnj