Do not call close() on the response_stream

src/StreamRequest.jl

@@ -146,7 +146,6 @@ function readbody(http::Stream, res::Response, response_stream, reached_redirect
         if reached_redirect_limit || !isredirect(res)
             res.body = body_was_streamed
             write(response_stream, http)
-            close(response_stream)
         end
     end
 end

test/async.jl

@@ -114,6 +114,7 @@ using Test, HTTP, JSON
                     try
                         stream = Base.BufferStream()
                         response = HTTP.request("GET", url; response_stream=stream, config...)
+                        close(stream)
 
                         if response.status != 200
                             @error "non-200 response" response=response

test/client.jl

@@ -69,8 +69,9 @@ end
         a = [JSON.parse(l) for l in split(chomp(String(bytes)), "\n")]
         totallen = length(bytes) # number of bytes to expect
 
-        io = Base.BufferStream()
+        io = IOBuffer()
         r = HTTP.get("$sch://httpbin.org/stream/100"; response_stream=io)
+        seekstart(io)
         @test status(r) == 200
 
         b = [JSON.parse(l) for l in eachline(io)]

test/loopback.jl

@@ -448,4 +448,4 @@ end
 
     HTTP.ConnectionPool.closeall()
 end # @static
-end
+end

test/messages.jl

@@ -117,10 +117,11 @@ using JSON
         @test r.status == 200
         r1 = JSON.parse(String(r.body))
 
-        io = Base.BufferStream()
+        io = IOBuffer()
         r = request(method, uri, response_stream=io, verbose=1)
+        seekstart(io)
         @test r.status == 200
-        r2 = JSON.parse(IOBuffer(read(io)))
+        r2 = JSON.parse(io)
         for (k, v) in r1
             if k == "headers"
                 for (k2, v2) in r1[k]
@@ -136,7 +137,7 @@ using JSON
 
     @testset "Body - JSON Parse" for protocol in protocols, method in http_writes
         uri = "$protocol://httpbin.org/$(lowercase(method))"
-        io = Base.BufferStream()
+        io = IOBuffer()
         r = request(method, uri, response_stream=io, verbose=1)
         @test r.status == 200
 
@@ -186,4 +187,4 @@ using JSON
         # don't display raw binary (non-Unicode) data:
         @test repr(Response(200, []; body=String([0xde,0xad,0xc1,0x71,0x1c]))) == "Response:\n\"\"\"\nHTTP/1.1 200 OK\r\n\r\n\n⋮\n5-byte body\n\"\"\""
     end
-end
+end