add negative value handling for isjson function
#730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 76.96% 76.71% -0.25%
==========================================
Files 37 37
Lines 2444 2444
==========================================
- Hits 1881 1875 -6
- Misses 563 569 +6
Continue to review full report at Codecov.
|
|
LGTM, can you add an entry in the CHANGELOG? |
AtsushiSakai
added a commit
to AtsushiSakai/HTTP.jl
that referenced
this pull request
Jun 30, 2021
|
Thank for your review. I updated the CHANGELOG.md. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added negative value handling for
isjsonfunction and added some tests for it to fix #728.