Avoid allocations in ascii_lc_isequal #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #724. Maybe in a perfect world, the compiler would be able to "see through" the calls to `Iterators.Stateful` and `zip` iterating through them to avoid allocating `Stateful` at all, but this also just feels like a case of a very low-level function trying to use high-level constructs. The proposed code here is an order of magnitude faster (~10x in the few cases I tested), avoids all allocations, and IMO, is simpler (I'm guessing most users don't immediately understand what `Iterators.Stateful` is for).
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
==========================================
+ Coverage 76.82% 76.87% +0.05%
==========================================
Files 37 37
Lines 2442 2443 +1
==========================================
+ Hits 1876 1878 +2
+ Misses 566 565 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #724. Maybe in a perfect world, the compiler would be able to "see
through" the calls to
Iterators.Statefulandzipiterating throughthem to avoid allocating
Statefulat all, but this also just feelslike a case of a very low-level function trying to use high-level
constructs. The proposed code here is an order of magnitude faster (~10x
in the few cases I tested), avoids all allocations, and IMO, is simpler
(I'm guessing most users don't immediately understand what
Iterators.Statefulis for).